Skip to content

fix: Animate avatars/icons that's using the .webp file format - #144

Merged
Dadadah merged 3 commits into
stoatchat:mainfrom
pparaxan:fix/webp-animation
Sep 28, 2026
Merged

Dadadah merged 3 commits into
stoatchat:mainfrom
pparaxan:fix/webp-animation

Conversation

@pparaxan

Copy link
Copy Markdown
Contributor

WebP can be animated, and so—it should have the same effect as normal GIFs—having the loop animation than it just being static.

As you may of known, WebP can also be animated and provides some
advantages, like having a smaller file sizes over GIF.

Though, the point is that WebP can be animated, and so—it should have
the same effect as normal GIFs - it having the loop animation than it
just being static.

Signed-off-by: xanners <xxdr@duck.com>
@pparaxan
pparaxan force-pushed the fix/webp-animation branch from 329082c to b691290 Compare March 16, 2026 18:20
@pparaxan

Copy link
Copy Markdown
Contributor Author

DCO'd

@Taureon

Taureon commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

I wonder if it makes sense here to make a new Set so instead of adding a bunch of new conditions in the future we just do animatableContentTypes.includes(this.contentType)

@pparaxan

Copy link
Copy Markdown
Contributor Author

I wonder if it makes sense here to make a new Set so instead of adding a bunch of new conditions in the future we just do animatableContentTypes.includes(this.contentType)

probably, but what other format are there that people uses on a regular meant for this case?

@Taureon

Taureon commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

I wonder if it makes sense here to make a new Set so instead of adding a bunch of new conditions in the future we just do animatableContentTypes.includes(this.contentType)

probably, but what other format are there that people uses on a regular meant for this case?

JXL?
That's one that comes to mind on the spot as I'm reading this notification

@Dadadah

Dadadah commented May 10, 2026

Copy link
Copy Markdown
Member

It looks like this should close stoatchat/for-web#827.

Were you able to test that this fix worked as expected @pparaxan ?

@pparaxan

Copy link
Copy Markdown
Contributor Author

Were you able to test that this fix worked as expected @pparaxan?

If you're talking about if I made my own self-hosted instance with the patches and all and see if it works—no, I just use the context available on how the code works and impl the fix as needed.

afaik—there was no code related to this in the frontend, only here in the javascript client, in which—the frontend pulls as a Git submodule

@pparaxan

Copy link
Copy Markdown
Contributor Author

It should work anyways because as says in the diff—that function is the one responsible for generating an URL of files.

@pparaxan

pparaxan commented May 10, 2026 •

Copy link
Copy Markdown
Contributor Author

afaik—there was no code related to this in the frontend, only here in the javascript client, in which—the frontend pulls as a Git submodule

I just tried it and it turns out somebody (in-between the time this PR was made and now) just made a fix over the frontend which I think eliminated the need for the /original query in general.

so I think if anything—you should just close this PR.

@Dadadah

Dadadah commented Aug 8, 2026

Copy link
Copy Markdown
Member

Closing.

FYI pparaxan you can choose to close PRs you opened yourself.

@Dadadah Dadadah closed this Aug 8, 2026
@pparaxan

pparaxan commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor Author

FYI pparaxan you can choose to close PRs you opened yourself.

Oh sorry, I just forgor that I made this PR. Should've closed it once I realised that it has been fixed.

edit: I don't use GitHub that much.

@Dadadah Dadadah reopened this Sep 28, 2026
@Dadadah

Dadadah commented Sep 28, 2026

Copy link
Copy Markdown
Member

This isn't fixed. And this change does in fact get the webp's to animate so I'm gonna merge it

Dadadah and others added 2 commits September 27, 2026 20:33
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
@Dadadah

Dadadah commented Sep 28, 2026

Copy link
Copy Markdown
Member

For future contributions, please ensure you run pnpm run fmt before opening a pr.

@Dadadah
Dadadah merged commit 6116338 into stoatchat:main Sep 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants